Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multimodality fix for llava #641

Open
wants to merge 7 commits into
base: habana_main
Choose a base branch
from
Open

Multimodality fix for llava #641

wants to merge 7 commits into from

Conversation

adobrzyniewicz-habana
Copy link

@adobrzyniewicz-habana adobrzyniewicz-habana commented Dec 17, 2024 •
edited by github-actions bot
Loading

Multimodality fix for llava after rebase

Fix for:

ERROR 12-16 12:31:11 engine.py:136]   File "/root/vllm-fork/vllm/multimodal/registry.py", line 97, in _get_plugin
ERROR 12-16 12:31:11 engine.py:136]     raise NotImplementedError(msg)
ERROR 12-16 12:31:11 engine.py:136] NotImplementedError: Unknown multi-modal data type: attention_mask

To run:

VLLM_SKIP_WARMUP=true python -m vllm.entrypoints.openai.api_server --port 8001 --model llava-hf/llava-1.5-7b-hf --enforce-eager --chat-template ./examples/template_llava.jinja

curl 'http://localhost:8001/v1/chat/completions' -k -H 'Content-Type: application/json' -d @- <<EOF
{
"model": "llava-hf/llava-1.5-7b-hf",
"messages": [
{
"role": "user",
"content": [
{
"type": "image_url",
"image_url": {
"url": "data:image/jpeg;base64,$(curl -s https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg | base64 -w 0)"
}
},
{
"type": "text",
"text": "What is in the picture?"
}
]
}
],
"temperature": 0.2,
"top_p": 0.1,
"top_k": 20,
"frequency_penalty": 0.2
}
EOF

Needs: #645

@adobrzyniewicz-habana adobrzyniewicz-habana added the habana Issues or PRs submitted by Habana Labs label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczykhabana madamczykhabana Awaiting requested review from madamczykhabana madamczykhabana is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
habana Issues or PRs submitted by Habana Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adobrzyniewicz-habana